Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation

To:	Christoph Egger <Christoph.Egger@xxxxxxx>, Keir Fraser <keir@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Fri, 15 Apr 2011 10:24:09 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 15 Apr 2011 02:24:53 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=GOYiS50NoIFgnXzQsKKD4ciDCjKQTj4MeMy2LDrRHVw=; b=sjpEhPh5IL+hih1iIwJsffg8INB3oDV79rh2ce+4y/NC9BvhqXZPZQqFe2dkNDCkVw E2Ze663/ojUjDO7r7Kks8YeV58k0qUstC9Ltp/Qomb2VyFYGyyAg076dWdQ0u6Z1XCjq yyTtKWtX/dTbaTD0G4BCvpgR+6/Esh0sNCQzU=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=C5k7G1GX9c2r96JcrtMjHjBa4L1LOHqwpoyNLkELnfnwmq2j7Rh4WGpRQI4Zp2zQuw +EOPd9CeDAj1q+G0UsIKZo3EYY8d7u8mRO32CrZOiBlfegt+e/pCDZu5oE7NOFovcPR1 qeKYRHnhcAW/P1yAkVrWpJqVAqYoDds+PhtrM=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4DA80B26.7060700@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acv7Tt++EactU4kBgE6lJylefcIsUg==
Thread-topic:	[Xen-devel] [PATCH] nestedhvm: ASID emulation
User-agent:	Microsoft-Entourage/12.28.0.101117

On 15/04/2011 10:08, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> You didn't notice my subtle error in switching n1 and n2 asid selection in
>> svm_asid_handle_vmrun()? ;-)
> 
> Oh, now that you mention it...

Yeah, I fixed it before I checked it in (xen-unstable:23229).

> A l2 smp guest actually boots up. Maybe I need to use more vcpus than I
> have physical cpus to hit that bug.

I think it would have been a source of very subtle quite hard-to-repro bugs.
Not something you'd pick up in a simple does-it-boot smoke test. So a pretty
nasty bug all round!

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation