WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] tools/libxl/libxl__build_device_model_args_new/old:

To: "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian.Jackson@xxxxxxxxxxxxx, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: [Xen-devel] [PATCH] tools/libxl/libxl__build_device_model_args_new/old: The condition is so strong that user has no chance to disable the vnc
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Fri, 15 Apr 2011 16:38:18 +0800
Cc:
Delivery-date: Fri, 15 Apr 2011 01:38:51 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=hYOGXYf1C/229Qv0uQDj1WFJuklzBbfz+Lyy3RmLmQ8=; b=oyXt/ZjACilmsU7UigeZaq87upQrg37IuMD5T3bk/hCrSgxv6RTDzKW6B4L6pHvh3c oqfJfmboBg3vggBDXzP4ArdmWqL2D6R78LHOprvC0DGecotW5imMkoybSH7OS/SWYzDT lctlufB9vzz8qAudZyR8hIMuRZ/i5luuYBx5s=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=PZ3mCDUKqR3GvGrLeeUCs7E/f1a4Tj6KLk536UBgHnt+EqGZMxG0XxgxauiUP3J/E9 qNOkrAexyLeKgd6MEsBRKE+ooH4qgA6T0/rnpqHgBTLeQ1pVPsNcs67oYdIXGPHRpKaI /ZX2PTdvbarXr3VP8uRgrDbtj2n31VpkKaqsY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Zhou Peng <zhoupeng@xxxxxxxxxxxxxxx>

tools/libxl/libxl__build_device_model_args_new/old: The condition is so strong that user has no chance to disable the vnc,
especially considering what has been done in parse_config_data(),which is not resonable with vnc option in vm-cfg file.
If user explicitly set "vnc=0", vnc should be disabled. User should have the chance to only use sdl, other remote display(spice) even nothing.

diff -r 41879bb8d174 -r 6871474a2a09 tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Fri Apr 15 09:51:14 2011 +0800
+++ b/tools/libxl/libxl_dm.c    Fri Apr 15 10:06:59 2011 +0800
@@ -55,7 +55,7 @@ static char ** libxl__build_device_model
     if (info->dom_name)
         flexarray_vappend(dm_args, "-domain-name", info->dom_name, NULL);
 
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         char *vncarg;
         if (info->vncdisplay) {
             if (info->vnclisten && strchr(info->vnclisten, ':') == NULL) {
@@ -205,7 +205,7 @@ static char ** libxl__build_device_model
     if (info->dom_name) {
         flexarray_vappend(dm_args, "-name", info->dom_name, NULL);
     }
-    if (info->vnc || info->vncdisplay || info->vnclisten || info->vncunused) {
+    if (info->vnc) {
         int display = 0;
         const char *listen = "127.0.0.1";
 

--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

Attachment: disable-vnc.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] tools/libxl/libxl__build_device_model_args_new/old: The condition is so strong that user has no chance to disable the vnc, ZhouPeng <=