 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] nestedhvm: xentrace support
| To: | Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] nestedhvm: xentrace support |
| From: | Keir Fraser <keir@xxxxxxx> |
| Date: | Thu, 14 Apr 2011 15:00:39 +0100 |
| Cc: | |
| Delivery-date: | Thu, 14 Apr 2011 07:02:07 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=CGJp2ru23UeQA2edszPUQBTAqMnKLf/H8jhhbT7dEQ8=; b=jRucChHj1UFoas9HV9cI+iA83eSuEeG0wz+SjcRtS0GL81xhzyAvYdDLwNejp9hA5f dNhlflH/CrIh1O4YqhTPm8ZZhTp2I7bl9YWKPchfGQfEgh2B+MzN5eIHEof45XTBm8Ry LdOgwteZzx5MLN5IawEImTw5+jLXedcVMXz9E= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=JmzzZifQnZnN04/8anQptQYaTEBLMfO6JAuGp10ZywT/HF9/AXVP349R/8bwyPWV5F rvtSAGHMjDFhyRi44fTm+dlnuyLg9cQajQUes+gRNTPGBWAj3KB7hD1DC/iSryJSHSTM 1AvhCGbM4x8YGdS/4lJJA0lU/e1MN1ul1/K4g= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4DA5C290.9060700@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acv6rFW9T31wyxQNvEGzTeLQjR7hPQ== |
| Thread-topic: | [Xen-devel] [PATCH] nestedhvm: xentrace support |
| User-agent: | Microsoft-Entourage/12.28.0.101117 |
On 13/04/2011 16:34, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > > Tracing facility for nested virtualization > > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx> I fixed this, by adding an extra argument to HVMTRACE_ND() -- it wasn't really valid to make the first argument be an arbitarry C expression, due to argument concatenation that then went on in the macro body. I also discarded the change to the VMENTRY record to add the guest EIP. Firstly, it was incomplete, because it did not handle 64-bit RIP. Secondly, it does not logically belong in this patch. Finally, George may have a reason for not including RIP in VMENTRY records (e.g., not that useful compared with the extra space taken up in trace records). So you'd need to submit a new patch and get an Ack from George (who is currently on holiday). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Re: [Xen-devel] How can I use grant table in domainU?, Konrad Rzeszutek Wilk |
|---|---|
| Next by Date: | Re: [Xen-devel] Dom0 crashed with xen4.0 and DEBIAN SQUEEZE AMD64, Stefano Stabellini |
| Previous by Thread: | [Xen-devel] [PATCH] nestedhvm: xentrace support, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] nestedhvm: xentrace support, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
