 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup)
| To: | Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup) |
| From: | Keir Fraser <keir@xxxxxxx> |
| Date: | Wed, 13 Apr 2011 14:28:40 +0100 |
| Cc: | |
| Delivery-date: | Wed, 13 Apr 2011 06:29:52 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=oFjVdxgrj3siXeiJQBjHbfqldm07uumUqd8hREA+qeo=; b=K+ILkSgHeqPHkp2ozjpGG1IjKhh602S2/Q9jeiR2BMnANXRYX9FhtEi8GxnL9WXNfQ G1Fm7A6INEbxhOnPJCa+wT/rEr0zoTl8rN+XYzms1gPZIcsAfKOsWYcUAvtgOasr7h9S 1ZrVZIUNv9G6dWXxj4JoR1s3SR74fFJIrBndI= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=e1V77d7ds3dH12WJVvllMRG3tdY05GLmzdqXlPKIy1ZYuOxxDZm6TUxj+kHu+FfyRi z91UXH0G/32ygw6t2tfOi11u5V7HTu5Iw2ue+2VMwDzsxJejzAfSmy7awaxBFhzvIHZI s1NqjoKe3MCU7rps/aT4QjnEQMsB6WJm3P7Ms= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201104131520.23648.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acv53rODQnpaPbaimUKACL/z43x7KA== |
| Thread-topic: | [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup) |
| User-agent: | Microsoft-Entourage/12.28.0.101117 |
On 13/04/2011 14:20, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >> On 13/04/2011 11:35, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: >>> Cleanup for ASID emulation: >>> - Use C99 integer types for asid numbers >>> >>> - asid.c: consistently use 'v' instead of 'curr' >> >> On what planet is that an improvement?? >> >> We use 'curr' as a convenient idiom to represent cached current. Whereas >> 'v' is supposed to represent an arbitrary vcpu. > > Oh, that's the difference. I thought 'curr' is just another random name for an > arbitrary vcpu. > > I will resend the patch w/o that hunk. I already applied the two cleanups that I didn't mind, as two separate changesets. And I've nacked your main patch so you can go take a look at that. :-) -- Keir >> >> I know it costs three extra characters per use, but it does make code >> easier to understand. >> >> -- Keir >> >>> - Introduce svm_invlpga() used in ASID emulation patch >>> >>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@xxxxxxxxxxxxxxxxxxx >> http://lists.xensource.com/xen-devel > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic, Konrad Rzeszutek Wilk |
| Previous by Thread: | Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup), Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] nestedhvm: ASID emulation (cleanup), Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
