WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]: libxc: set all VCPU's online by default in HVM

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: libxc: set all VCPU's online by default in HVM info table
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Thu, 7 Apr 2011 11:37:06 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Delivery-date: Thu, 07 Apr 2011 03:38:02 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qSQpcz5zFv7nmH3pBlOwmNwtCvid0AAuVTV3P5P95vg=; b=udm4YcQBWgUBv70WcmQfCoHwTQUv+RpYgth5Ahsp5Coo452NXMfo0rqIAj+uEN55xD 1YfRcRXIUne4jZSz9S0Nqfkz642QFvweJ947uLkTnMOOoSJ6hzSDX5BkdKRfvm92tJza blNFSWPlHvmhlccX8AqciYyb8Ea0HdQHqULUg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=l8t677DH5YcT1t/jdqfyr90Rgpj4S4vFM+I2Hr2sYNnbzbWDfom6C/j+9yKiAn8wFL TTOEvaTkAjHft3Cj3BGjMN/lbkV4JHwgGXxnYeH/4WI0IAXq4R02klqzbSaBD7r3G5RY 5rpFNeGtzb56kBkpKLyWCb7jkx7F5n3RTR610=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1102161324000.2826@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1297438975.29419.16.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1102161324000.2826@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
This patch seems to have been acked, but never actually applied.  It's
probably still worth applying at least to -unstable.  I'd consider
backporting it to 4.1 as well...

 -George

On Wed, Feb 16, 2011 at 1:24 PM, Stefano Stabellini
<stefano.stabellini@xxxxxxxxxxxxx> wrote:
> On Fri, 11 Feb 2011, Gianni Tedesco wrote:
>> This sets a saner default for the cpu-online-map by setting all bits to
>> 1. The default assumption ought to be that nr-vcpus ==
>> nr-vcpus-at-start. If that is not true, then the toolstack must modify
>> the bitmap, but if it is true, the toolstack oughtn't need to do
>> anything further.
>>
>> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
>>
>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>
>
>> diff -r a0662e3bedea tools/libxc/xc_hvm_build.c
>> --- a/tools/libxc/xc_hvm_build.c      Fri Feb 11 14:28:14 2011 +0000
>> +++ b/tools/libxc/xc_hvm_build.c      Fri Feb 11 14:39:47 2011 +0000
>> @@ -70,6 +70,7 @@ static void build_hvm_info(void *hvm_inf
>>      hvm_info->acpi_enabled = 1;
>>      hvm_info->apic_mode = 1;
>>      hvm_info->nr_vcpus = 1;
>> +    memset(hvm_info->vcpu_online, 0xff, sizeof(hvm_info->vcpu_online));
>>
>>      /* Memory parameters. */
>>      hvm_info->low_mem_pgend = lowmem_end >> PAGE_SHIFT;
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH]: libxc: set all VCPU's online by default in HVM info table, George Dunlap <=