WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN

To: Daniel Kiper <dkiper@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 2/3] mm: Add SECTION_ALIGN_UP() and SECTION_ALIGN_DOWN() macro
From: David Rientjes <rientjes@xxxxxxxxxx>
Date: Tue, 29 Mar 2011 14:11:53 -0700 (PDT)
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, haicheng.li@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx, dave@xxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, andi.kleen@xxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, wdauchy@xxxxxxxxx
Delivery-date: Wed, 06 Apr 2011 18:26:54 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1301433159; bh=u+YO2DOouL6rfcPfNWHvg61UEOs=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=gwIMYXh66inrDgc3sw/hqr25khC71Zlz9OXJOPUfuw6QzmhT3al1VP4iYCgg6ttu4 KGXRqBEoaBMthgBtGxOmQ==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:date:from:x-x-sender:to:cc:subject:in-reply-to :message-id:references:user-agent:mime-version:content-type; bh=H5RpnYAAdLUK1SizyQwXgH8OdJEcgwsjW7a4p+83s/I=; b=YtC2qG11W2XG340g9tQcpA1ExAFt7S/IDX4dD54A7OWO3GSlYX5UCMxKXJpnfrxAXi dVHtQwIhKMNqUCkh0nvQ==
Domainkey-signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=WTsuxaWk3tXiCxjgPiuKePx0oh/ji5qAoftYrIfC4CVzikB7sA5cHfGRgJ11wJYqpt ebnAZculQT8b1NBtktiQ==
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110329173221.GB30387@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110328092412.GC13826@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1103281545220.7148@xxxxxxxxxxxxxxxxxxxxxxxxx> <20110329173221.GB30387@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Tue, 29 Mar 2011, Daniel Kiper wrote:

> > These are only valid for CONFIG_SPARSEMEM, so they need to be defined 
> > conditionally.
> 
> OK, however, I think that pfn_to_section_nr()/section_nr_to_pfn()
> should be defined conditionally, too.
> 

Yes, and you could try removing this from include/linux/mm.h:

#ifndef PFN_SECTION_SHIFT
#define PFN_SECTION_SHIFT 0 
#endif

then we'll reveal anything using these conversion macros that don't rely 
on sparsemem.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>