WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3 of 7] xenpaging: remove srand call

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 7] xenpaging: remove srand call
From: Patrick Colp <pjcolp@xxxxxxxxx>
Date: Thu, 31 Mar 2011 10:48:15 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 31 Mar 2011 10:49:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <cd35892de8ff2388aa46.1301592980@localhost>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1301592977@localhost> <cd35892de8ff2388aa46.1301592980@localhost>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 31 March 2011 10:36, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1301591570 -7200
> # Node ID cd35892de8ff2388aa46e3768393f217a3c63521
> # Parent  a811d86a48f400cd541500e0e6ae765fdcd02ef9
> xenpaging: remove srand call
>
> The policy uses now a linear algorithm instead of picking random gfn
> numbers.  Remove the call to srand().

Is a linear algorithm better than random?


Patrick


>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> diff -r a811d86a48f4 -r cd35892de8ff tools/xenpaging/xenpaging.c
> --- a/tools/xenpaging/xenpaging.c       Thu Mar 31 19:11:57 2011 +0200
> +++ b/tools/xenpaging/xenpaging.c       Thu Mar 31 19:12:50 2011 +0200
> @@ -544,9 +544,6 @@
>     domain_id = atoi(argv[1]);
>     num_pages = atoi(argv[2]);
>
> -    /* Seed random-number generator */
> -    srand(time(NULL));
> -
>     /* Initialise domain paging */
>     paging = xenpaging_init(domain_id);
>     if ( paging == NULL )
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel