Re: [Xen-devel] [PATCH] xenstore-stat

[Frank Pan <frankpzh@xxxxxxxxx>]

> You can sort of get this from "xenstore-ls -p" but a stat option seems
> like a worthwhile addition.

Didn't know this before. :(

> I think I'd suggest pulling the core of the new functionality out of
> perform() and into a new function do_stat().

Good idea.

>> +    case MODE_stat:
>> +        mstr = incl_mode ? "stat " : "";
>> +        errx(1, "Usage: %s %s[-h] [-s] key [...]", progname, mstr);
>
> Does it deal with multiple key names as a paramter? If not then I guess
> the [...] can be dropped, or else the necessary support added.

Sure, xenstore-stat can accept multiple keys.

>> +static const char *
>> +perm_type_str(int perm_type)
>> +{
>
> Can you use xs_perm_to_string here instead?

I'd like to make it more similar to unix permissions. ("-rwx")
I think it's more straightforward than "w/r/b/n".
Is this a good idea?

> Unused parameter?

Yes. My compiler did not complain, weird.

-- 
潘震皓, Frank Pan

Computer Science and Technology
Tsinghua University

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel