Re: [Xen-devel] [PATCH 5 of 5] tools: ocaml: rename nic_remove to nic_del, for consistency with libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-03-28 at 13:26 +0100, Dave Scott wrote:
> # HG changeset patch
> # User David Scott <dave.scott@xxxxxxxxxxxxx>
> # Date 1301314652 -3600
> # Node ID bb7e56721316582cc42527e97e7651a8a369c33c
> # Parent  455cc73ea6268d54bc94e4c39ee954cef107f88b
> tools: ocaml: rename nic_remove to nic_del, for consistency with libxl.

At least disk has the same issue, other libxl functions use _remove and
others use _{hard,soft}_shutdown. Sigh :-(

> Signed-off-by: David Scott <dave.scott@xxxxxxxxxxxxx>
> 
> diff -r 455cc73ea626 -r bb7e56721316 tools/ocaml/libs/xl/xl.ml
> --- a/tools/ocaml/libs/xl/xl.ml       Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl.ml       Mon Mar 28 13:17:32 2011 +0100
> @@ -184,7 +184,7 @@
>  external disk_remove : disk_info -> domid -> unit = "stub_xl_disk_remove"
>  
>  external nic_add : Nic_info.t -> domid -> unit = "stub_xl_nic_add"
> -external nic_remove : disk_info -> domid -> unit = "stub_xl_nic_remove"
> +external nic_del : Nic_info.t -> domid -> unit = "stub_xl_nic_del"
>  
>  external console_add : console_info -> build_state -> domid -> unit = 
> "stub_xl_console_add"
>  
> diff -r 455cc73ea626 -r bb7e56721316 tools/ocaml/libs/xl/xl.mli
> --- a/tools/ocaml/libs/xl/xl.mli      Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl.mli      Mon Mar 28 13:17:32 2011 +0100
> @@ -184,7 +184,7 @@
>  external disk_remove : disk_info -> domid -> unit = "stub_xl_disk_remove"
>  
>  external nic_add : Nic_info.t -> domid -> unit = "stub_xl_nic_add"
> -external nic_remove : disk_info -> domid -> unit = "stub_xl_nic_remove"
> +external nic_del : Nic_info.t -> domid -> unit = "stub_xl_nic_del"
>  
>  external console_add : console_info -> build_state -> domid -> unit = 
> "stub_xl_console_add"
>  
> diff -r 455cc73ea626 -r bb7e56721316 tools/ocaml/libs/xl/xl_stubs.c
> --- a/tools/ocaml/libs/xl/xl_stubs.c  Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl_stubs.c  Mon Mar 28 13:17:32 2011 +0100
> @@ -416,7 +416,7 @@
>       CAMLreturn(Val_unit);
>  }
>  
> -value stub_xl_nic_remove(value info, value domid)
> +value stub_xl_nic_del(value info, value domid)
>  {
>       CAMLparam2(info, domid);
>       libxl_device_nic c_info;
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel