WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4/12] VTPM mini-os: Mini-os machine specific head

To: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 4/12] VTPM mini-os: Mini-os machine specific headers
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Mon, 14 Mar 2011 18:35:57 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Mar 2011 10:53:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D7E4A20.1050002@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4D7AA5B1.8060603@xxxxxxxxxx> <20110312003112.GE4922@xxxxxxxxxxxxxxxxxxxxxxxxx> <4D7E4A20.1050002@xxxxxxxxxx>
Resent-date: Mon, 14 Mar 2011 18:52:27 +0100
Resent-from: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Resent-message-id: <20110314175227.GD4370@xxxxxxxxxxxxxxxxxxxxxxxxx>
Resent-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Matthew Fioravante, le Mon 14 Mar 2011 13:02:24 -0400, a écrit :
> Which part? The check for gcc version >= 4.3 or the #defines for bswap_XX?
> 
> I think its correct

The 64bit #define.  If it's really meant to be using __builtin_bswap32 instead 
of
__builtin_bswap64, a comment should say why :)

> On 03/11/2011 07:31 PM, Samuel Thibault wrote:
> >Matthew Fioravante, le Fri 11 Mar 2011 17:44:01 -0500, a écrit :
> >>+/* Use gcc optimized versions if they exist */
> >>+#if __GNUC__>  4 || (__GNUC__ == 4&&  __GNUC_MINOR__>= 3)
> >>+#define bswap_32(v) __builtin_bswap32(v)
> >>+#define bswap_64(v) __builtin_bswap32(v)
> >Typo here, right?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel