xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing device mod

from [Ian Jackson]

[Permanent Link][Original]

To:	Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing device model
From:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date:	Thu, 10 Mar 2011 18:19:07 +0000
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 10 Mar 2011 10:21:04 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D759AA9.3030403@xxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups:	chiark.mail.xen.devel
References:	<4D759AA9.3030403@xxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Jim Fehlig writes ("[Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing 
device model"):
> While developing libvirt libxl driver I noticed that terminating the
> client causes any qemu-dm processes indirectly started by the client to
> also terminate.  Calling setsid(2) before exec'ing qemu-dm resolves the
> issue but I'm not quite sure about the placement of the setsid() call or
> any unforeseen side-affects of its use.  Comments welcome.

Thanks, I think your patch is correct, and has the setsid in the right
place.  libxl_spawn_spawn was another possibility but I think it's
probably better to do it in the caller.

Applied (with my and Stefano's ack) to 4.1 and unstable.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing device model, Jim Fehlig Re: [Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing device model, Ian Jackson <=

Previous by Date:	Re: [Xen-devel] [PATCH] fbfront: advertise either absolute or relative coordinates, Olaf Hering
Next by Date:	Re: [Xen-devel] [PATCH] libxc: osdep: convert hypercall buffer allocation, Ian Jackson
Previous by Thread:	[Xen-devel] [PATCH] libxl: Call setsid(2) before exec'ing device model, Jim Fehlig
Next by Thread:	[Xen-devel] [xen-unstable test] 6334: regressions - FAIL, xen . org
Indexes:	[Date] [Thread] [Top] [All Lists]