 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some
| To: | Jan Beulich <JBeulich@xxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Tue, 08 Mar 2011 16:29:20 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 08 Mar 2011 08:29:58 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=YH0cZr1ILAzpl5YfihuaItJ40M1uNbnwx/ghrx+5ex4=; b=YfFp4pWl5vxzudOyJyS1OxMrQ5/CUXggqC8mLeHKotLLPHOPk7hW7TH/OOGNQJvhwd Y9rPnwAfjPBoX1eqAjxW2UYbZhzR3Na/fmaqfd6UUw8eTxiM/ocbukW/LZ0fM9czY1Qt rYggs/5pjAlmbZ7vaUdQU1xO06ZxJxQqRyuKk= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=u5TPiML2kwnq+8NmMB4x1qpjfoK7V7eRLTNfo8ejqnHjGgJ3fplYPjVAVivu22SYTC RoLvBt45EYFjhYdm7uD53T7ijkw4hUQvtf9lPLx44XdsQmob1SBdsIPn1Z4OvwQ7sL3N VtgxdXOf1j48aNPGd+OprhvDDMxGEFuIhEWeE= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4D761A880200007800035223@xxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcvdrfnJYoH9YQvJDk+gYrSLeP+9ig== |
| Thread-topic: | [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions |
| User-agent: | Microsoft-Entourage/12.28.0.101117 |
On 08/03/2011 11:01, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>> On 08.03.11 at 11:44, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>> At 09:27 +0000 on 08 Mar (1299576427), Jan Beulich wrote:
>>>>>> On 07.03.11 at 12:26, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
>>>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c Mon Mar 07 11:21:11 2011 +0000
>>>> @@ -2678,7 +2678,7 @@ x86_emulate(
>>>> emulate_fpu_insn_memsrc("fiaddl", src.val);
>>>> break;
>>>> case 1: /* fimul m64i */
>>>> - emulate_fpu_insn_memsrc("fimul", src.val);
>>>> + emulate_fpu_insn_memsrc("fimuls", src.val);
>>>
>>> fimull.
>>
>> fimuls is what the previous code generates, but it does look like that
>> was wrong. I'll fix it, thanks.
>
> And perhaps that fix by itself should go into 4.1/4.0 too.
Done. Also I fixed the comments to read 'm32i' and also noted and fixed
src.bytes=ea.bytes=4 rather than 8.
-- Keir
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | Re: [Xen-devel] [PATCH] Fix rcu domain locking for transitive grants, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Fix rcu domain locking for transitive grants, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions, Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH 4 of 8] xen: adjust cpumask initializers to suit clang's incomplete gccisms, Tim Deegan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
