WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] kernel: Fix pvops build on 2.6.38.

To: Daniel Stodden <daniel.stodden@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] kernel: Fix pvops build on 2.6.38.
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 4 Mar 2011 10:19:59 +0000
Cc: "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 04 Mar 2011 02:22:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1299185575-17375-2-git-send-email-daniel.stodden@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1299185575-17375-1-git-send-email-daniel.stodden@xxxxxxxxxx> <1299185575-17375-2-git-send-email-daniel.stodden@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-03-03 at 20:52 +0000, Daniel Stodden wrote:
> ---
>  arch/x86/xen/time.c  |    2 +-
>  drivers/xen/events.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
> index 2e2d370..1f48076 100644
> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -399,7 +399,7 @@ void xen_setup_timer(int cpu)
>       irq = bind_virq_to_irqhandler(VIRQ_TIMER, cpu, xen_timer_interrupt,
>                                     IRQF_DISABLED|IRQF_PERCPU|
>                                     IRQF_NOBALANCING|IRQF_TIMER|
> -                                   IRQF_FORCE_RESUME,
> +                                   IRQF_NO_SUSPEND,
>                                     name, NULL);
>  
>       evt = &per_cpu(xen_clock_events, cpu);
> diff --git a/drivers/xen/events.c b/drivers/xen/events.c
> index 916d9a8..d4251ad 100644
> --- a/drivers/xen/events.c
> +++ b/drivers/xen/events.c
> @@ -1026,7 +1026,7 @@ int bind_ipi_to_irqhandler(enum ipi_vector ipi,
>       if (irq < 0)
>               return irq;
>  
> -     irqflags |= IRQF_NO_SUSPEND | IRQF_FORCE_RESUME;
> +     irqflags |= IRQF_NO_SUSPEND;
>       retval = request_irq(irq, handler, irqflags, devname, dev_id);
>       if (retval != 0) {
>               unbind_from_irq(irq);

These flags aren't interchangeable like this, they are dependent on each
other. IRQF_NO_SUSPEND does what it says but IRQF_FORCE_RESUME means
"resume even if IRQF_NO_SUSPEND".

IIRC we want both for IPIs but VIRQ_TIMER needs neither, since the
correct flags are included in IRQF_TIMER already. Nothing else on the
Xen side should be using either flag AFAIK.

However, I don't know of any tree which doesn't have this correct
already. Both Jeremy and Konrad's branches with 2.6.38 in the name are
correct.

I think you need to figure out where you got this tree from (and make
sure you are up to date with it) so we can tell if it is in error or
not.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>