WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Wed, 23 Feb 2011 11:35:40 +0000
Cc:
Delivery-date: Wed, 23 Feb 2011 03:36:40 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=NjJuKRzeftsonIR/YNKtmXOCXf6F4qD/g93IJUfOfEw=; b=fooWLErFG3qwEymzRxfIYaVlvPG9s34UMByYudwEgYcTajhC6f/i0WZyCNfL6yEMsp 5ZalFxRMpxXtTJdqnibSCLx3XjDoReItXt1Qfd3X7T8c/MDKIVGKVrRRbjdAhSzlBI6z FQvkNmbG04yLwhI7Gn6JRrKnR3bTA5EUDkr/o=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ucyHTePAYarQCZfLtXLPUPL9dSFE9PfozLDSWSSm5LqF1+RCajLzR/qTr+2pVNpiqf b9VkUa6SmvBH9u204NG4l5gXxvzhFzD6nDKeFvxTtwKUIRB/ogQsBYOP/kei6n3WxSXY KPSulpE2vbBEDeAmhNopHyUuXygkhMfsdE07I=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D64FC8102000078000334AF@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvTTcwUmgC0q2XUJ0GX6/lHZCuOvw==
Thread-topic: [Xen-devel] [PATCH] amd-k8-mce: remove a stray break statement
User-agent: Microsoft-Entourage/12.28.0.101117
On 23/02/2011 11:24, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

> This was a leftover of converting from a switch to an if/else somewhere
> between 3.4 and 4.0.

So the patch is for 4.0-testing and unstable?

 -- Keir

> It also looks suspicious that MCEQUIRK_K7_BANK0 is not actually used
> anywhere. Perhaps amd_k7_mcheck_init() and amd_k8_mcheck_init() were
> intended to get (partially) folded?
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> --- a/xen/arch/x86/cpu/mcheck/amd_k8.c
> +++ b/xen/arch/x86/cpu/mcheck/amd_k8.c
> @@ -92,7 +92,6 @@ enum mcheck_type amd_k8_mcheck_init(stru
> /* Enable error reporting of all errors */
> wrmsrl(MSR_IA32_MCx_CTL(i), 0xffffffffffffffffULL);
> wrmsrl(MSR_IA32_MCx_STATUS(i), 0x0ULL);
> -   break;
> }
> }
>  
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>