WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] correct xl cpupool-create with extra parameters

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] correct xl cpupool-create with extra parameters
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 14 Feb 2011 16:55:07 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Feb 2011 08:55:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <78995dd5b66b19395412.1297675624@nehalem1>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <78995dd5b66b19395412.1297675624@nehalem1>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Juergen Gross writes ("[Xen-devel] [PATCH] correct xl cpupool-create with extra 
parameters"):
> xl cpupool-create won't take always extra parameters specified on the command
> line, as a 0-byte is missing at the end of the configuration file contents.

Thanks, this looks right to me; I have applied it.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Having said that, I think this approach (reallocing the config data
buffer and tacking the args on the end) is pretty nasty really.  The
right thing would be probably call xlu_cfg_read* more than once.
Let's not do that now, though.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>