Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 11 Jan 2011, Ian Jackson wrote:
> Stefano Stabellini writes ("[Xen-devel] [PATCH] libxl: implement trigger 
> s3resume"):
> > Implement trigger s3resume
> > 
> > This is the equivalent of xm trigger s3resume and it is implemented the
> > same way: using an ACPI state change.
> 
> The code here is a bit odd - callers are apparently expected to pass
> strings rather than enums through into the libxl API.  I think
> trigger_type_from_string ought to be libxlu_...
> 
> But given the current code and the state of freeze we shouldn't do
> that now.
> 
> This is clearly a low-impact new feature and I'm inclined to make
> exception to the freeze for it.  Have you tested the patch ?  Anyone
> object ?

I forgot to reply to this, but yes I tested it.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel