 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it i
| To: | Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts |
| From: | Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx> |
| Date: | Tue, 08 Feb 2011 14:04:05 -0500 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 08 Feb 2011 11:05:05 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=DZ0LbZrYvT9fEVG6/LLi6Xq9gEGgm/nevFUA83inydw=; b=xKR7Pzs7cvb+bd2yFf/eNCdYXq4oIxW5xmzua/gpF8f5x96dwdxE1PlAR2VGxcySr5 4sMlfwAAX3R5qmchVyECqPiBw+wt8RVT9WUIVjQya7jbYGNqvgVwy0iblLnhFAnT5zvV pn3ap9cbps6HBEnouGquw0AFuiGuR03Cslp3U= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=WAtpuUQu4tqfMKTPPMDf6tfY3ZVlKpK4+Q8ZDrHOpGdSrTaC7igqG3sVxhy68dVAfx 8piMBSy0WtNVEWpI+hgAx3ZtHGf9+MAfM1giNsE5Z0H2T109GWm3G20AZc2dnvUPCsJE KtAbFj3gu9hhQEYCrq0DIs2wObeJlqMTzNPBQ= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <alpine.DEB.2.00.1102081542120.7277@kaball-desktop> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4D50628A.2000307@xxxxxxxxx> <alpine.DEB.2.00.1102081542120.7277@kaball-desktop> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.24 (X11/20101027) |
>> diff -r e4406b9fb064 tools/libxl/libxl_device.c
>> --- a/tools/libxl/libxl_device.c Mon Feb 07 15:04:32 2011 +0000
>> +++ b/tools/libxl/libxl_device.c Mon Feb 07 11:28:10 2011 -0500
>> @@ -121,31 +121,24 @@ out:
>> return rc;
>> }
>>
>> -char *libxl__device_disk_string_of_phystype(libxl_disk_phystype phystype)
>> +char *libxl__device_disk_string_of_format(libxl_disk_format format)
>> {
>> - switch (phystype) {
>> - case PHYSTYPE_QCOW: return "qcow";
>> - case PHYSTYPE_QCOW2: return "qcow2";
>> - case PHYSTYPE_VHD: return "vhd";
>> - case PHYSTYPE_AIO: return "aio";
>> - case PHYSTYPE_FILE: return "file";
>> - case PHYSTYPE_PHY: return "phy";
>> - case PHYSTYPE_EMPTY: return "file";
>> - default: return NULL;
>> + switch (format) {
>> + case DISK_FORMAT_QCOW: return "qcow";
>> + case DISK_FORMAT_QCOW2: return "qcow2";
>> + case DISK_FORMAT_VHD: return "vhd";
>> + case DISK_FORMAT_RAW:
>> + case DISK_FORMAT_EMPTY: return "file";
>
> This should be return "aio".
>
When I tested, both "aio" and "file" worked and I went with "file". But if it
is better to go with "aio", I will do that.
Kamala
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts, Kamala Narasimhan |
|---|---|
| Next by Date: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts, Stefano Stabellini |
| Previous by Thread: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts, Stefano Stabellini |
| Next by Thread: | Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts, Stefano Stabellini |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
