Re: [Xen-devel] [PATCH] amd iommu: Do not adjust paging mode for

To:	Wei Wang2 <wei.wang2@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] amd iommu: Do not adjust paging mode for dom0 devices
From:	Keir Fraser <keir@xxxxxxx>
Date:	Sun, 06 Feb 2011 16:58:18 +0000
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Sun, 06 Feb 2011 09:00:03 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=l+ixAGDZvO3s1GjK+4johL+UwzRPDl3aTkhNOn+HDNM=; b=f5uCAL6o0qRrunkP7ks9DLLO9y0qPHR/DXjC8sUh/a+Ji2oOwUKm3snHlpLq0LIftZ a1akUffIMvoonaH9Zqyoq0v4asU7qC/i287wPAKMel9OmgdTPLsg0qMVBLky1qdJOkOI VHf/9E2YcI0x59d0HvixvR7TENwQ/0MZVjQRY=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=jl6/IZ6NmDOCDMbDjua6qVYdh92YxtIvZaVQz4FP5ldnNFNg6i5b3PKqErp1QY91wa fSNcA8d7ZHhUWKYOdTml5YpeGH3EIUoBr7kO9FbxuwigHF2xDvWGztlYVPEWRT8ROjTq VIF160oMJ+FsoPY+mqHJ3bPTdJ3Uyiu4H1uDs=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<201102011834.02121.wei.wang2@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcvGHw1S+PNXCizB/U+bqpi1z4Qyyw==
Thread-topic:	[Xen-devel] [PATCH] amd iommu: Do not adjust paging mode for dom0 devices
User-agent:	Microsoft-Entourage/12.28.0.101117

On 01/02/2011 17:34, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> Keir
> Here is another small patch to fix consistency issue of paging mode when
> return passthru devices back to dom0. In this case, paging mode should not be
> adjusted, since dom0->max_pages = ~0U.

The call to get_paging_mode() in amd_iommu_domain_init() looks sensible
enough. Why is a call needed in reassign_device() at all? Checking for dom0
in reassign_device just looks like a fragile hack.

 -- Keir

> Thanks,
> Wei
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> Advanced Micro Devices GmbH
> Sitz: Dornach, Gemeinde Aschheim,
> Landkreis München Registergericht München,
> HRB Nr. 43632
> WEEE-Reg-Nr: DE 12919551
> Geschäftsführer:
> Alberto Bozzo, Andrew Bowd
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] amd iommu: Do not adjust paging mode for dom0 de