WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] hvmloader: add "wakeup from S4 on RTC alarm" bit to

To: xen-devel@xxxxxxxxxxxxxxxxxxx
To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] hvmloader: add "wakeup from S4 on RTC alarm" bit to ACPI FADT
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Fri, 4 Feb 2011 14:52:07 +0100
Delivery-date: Fri, 04 Feb 2011 05:53:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.7.3
# HG changeset patch
# User Paolo Bonzini <pbonzini@xxxxxxxxxx>
# Date 1296827299 -3600
# Node ID c923816861a96328aaf3d5ba8939fd9b4c441cd0
# Parent  4cd3bd56fc0343031085b7e466e3022816b1b5dc
hvmloader: add "wakeup from S4 on RTC alarm" bit to ACPI FADT

Testing Xen with Microsoft's Windows logo tests reveals a non-fatal
failure in the "CHAOS" test (more precisely in the PwrTest subjob).

The test expects to be able to hibernate the machine and have it
power up again via the RTC.  We do not really care about implementing
the exact timing in the management (and neither does MS) so their
request can be easily by manually restarting the VM or even via
on_poweroff="restart" (granted, that's not something you'd usually do).

Ok?

Paolo

diff --git a/tools/firmware/hvmloader/acpi/static_tables.c 
b/tools/firmware/hvmloader/acpi/static_tables.c
--- a/tools/firmware/hvmloader/acpi/static_tables.c
+++ b/tools/firmware/hvmloader/acpi/static_tables.c
@@ -71,7 +71,8 @@ struct acpi_20_fadt Fadt = {
     .flags = (ACPI_PROC_C1 |
               ACPI_WBINVD |
               ACPI_FIX_RTC | ACPI_TMR_VAL_EXT |
-              ACPI_USE_PLATFORM_CLOCK),
+              ACPI_USE_PLATFORM_CLOCK |
+              ACPI_RTC_S4),
 
     .reset_reg = {
         .address_space_id    = ACPI_SYSTEM_IO,



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel