Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split

To:	George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Fri, 28 Jan 2011 12:01:52 +0100
Cc:	Andre Przywara <andre.przywara@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date:	Fri, 28 Jan 2011 03:03:08 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1296212515; x=1327748515; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4D42A220.4030908@xxxxxxxxxxxxxx>\|Date:=20 Fri,=2028=20Jan=202011=2012:01:52=20+0100\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20George=20Dunlap=20<George.Dunlap@xxxxxxxxxxx om>\|CC:=20Andre=20Przywara=20<andre.przywara@xxxxxxx>,=20 =0D=0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lis ts.xensource.com>,=0D=0A=20Ian=20Jackson=20<Ian.Jackson@e u.citrix.com>\|Subject:=20Re:=20[Xen-devel]=20[PATCH]:=20x l:=20fix=20broken=20cpupool-numa-split\|References:=20<4D4 1E547.5000902@xxxxxxx>=09<4D426189.1030001@xxxxxxxxxxxxxx >=20<AANLkTi=3DbM36G-+VMCQA6zvbXxdH_z-hdqX7kxRv1XBY5@mail .gmail.com>\|In-Reply-To:=20<AANLkTi=3DbM36G-+VMCQA6zvbXxd H_z-hdqX7kxRv1XBY5@xxxxxxxxxxxxxx> \|Content-Transfer-Encoding:=207bit; bh=I29O2jzzzWzD8dMbd2cs9gxaORsKO/5jb7ng/3iAV+g=; b=tpWwRiD50gtoPzT3ouo29MfTTvNMGdCXgUr82RclgfAg90xJ3EsxF1gD Ju6/VPJGCaHhNG89l8wF2QKylEpTQHLvZTGfdEl11lgP62Wm8ILq6FgQs v63piS3vFYy1w2sP0lRhwxeQC4JQYBxTeuUJZL3pouNjmOPwpY5Vw8jVw aQ6KS42M71y9tdRR0Nl6ySGqQuWw0E5FiNWyGJwUSqjctlWdx3rwefcKR E2Xf4PSUVEoMueUvxpYcSIdfsja3l;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=MtsPAGoAIOSXFZsyCP7bc0gDcTiiCgySo6/Y2DvQ5U+1cRwwNn8GuCTT 2i9skl0Om/6YtGEp9DD/uh0BLhAkslJ17SancZqVp1Q1jHr11+NHc5ROd j2mmBOYzfsK08YvIHOMP8AwXLdSV+ldBI90+nP3OuJpJmK62jbui74j8d wHjOTKAY+12ObcUInb34vt2UYwE5ZSk5I74ZbOKJ0yLVdKrx2wyWBmtWI W/HBD5FU4heKE1bebccwXMMWdfTY4;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<AANLkTi=bM36G-+VMCQA6zvbXxdH_z-hdqX7kxRv1XBY5@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4D41E547.5000902@xxxxxxx> <4D426189.1030001@xxxxxxxxxxxxxx> <AANLkTi=bM36G-+VMCQA6zvbXxdH_z-hdqX7kxRv1XBY5@xxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

On 01/28/11 11:53, George Dunlap wrote:

On Fri, Jan 28, 2011 at 6:26 AM, Juergen Gross
<juergen.gross@xxxxxxxxxxxxxx>  wrote:

On 01/27/11 22:36, Andre Przywara wrote:


Hi,

the implementation of xl cpupool-numa-split is broken. It basically
deals with only one poolid, but there are two to consider: the one from
the original root CPUpool, the other from the newly created one.


Uhh, silly copy and paste error! I think it happened when I introduced
libxl_cpupool_cpuadd_node()...
The correction is much easier. The root poolid is always 0. See attached
patch.


Re patch itself: Acked-by: George Dunlap<george.dunlap@xxxxxxxxxx>

Re the cpupool interface:

Hang on; if the root poolid is always 0, why does xc_cpupool_create()
interpret a poolid of 0 as "XEN_SYSCTL_CPUPOOL_PAR_ANY"?  Doesn't that
mean that if you're trying to create a new cpupool from cpus in the
root pool, that you might get cpus from other pools?


No. It just creates a cpupool. As cpupool 0 is always created by the
hypervisor, it can't be created via libxc. So specifying 0 as poolid
selects the next free id.

The cpus are allocated later.


If not, what's the point of the "CPUPOOL_PAR_ANY" parsing?


Perhaps you just don't care which poolid you get?


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split