Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtua

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file
From:	Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Date:	Tue, 25 Jan 2011 22:07:19 -0500
Cc:	Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date:	Tue, 25 Jan 2011 19:08:16 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=N2dG5eoWUMjdI1s+dQBmhVez+E8sKao3XpolUsZThLE=; b=lzWcfnm8X4Yba9rQINTd9i4qw52GxlHSlttu11kNpfMoJyi2JjgQt+wrgcEdhawrJL AXywK5lOXf5/fYN944SgRdJoMK231Eu6n5ru+JFCxlMRTJ6zz1KLI92703+ctZwkdD10 405+5k6nXhLF9K5+SgHvJK/ihi0Cn1FliTOHM=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=SgEfGTU3ss66Yxf1rzrMaBXkoxEVQindjUcEsxhsj4JnbSRkKxGOOS9wu5ZqkOwNhb 7Gd5FzztqzpMUyXALNlbIBtqer3XhlB5uCQaatBITTljUiFMPbRKSkE6OXCTLOThL+VQ 28ibMpisFhg+6tMbf+jj14lGqFc5P0X/+eFQg=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19775.4623.927492.247420@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<AANLkTimSUym0u+SNm0AvNp3AZQQFspetAaXmNShkPJd4@xxxxxxxxxxxxxx> <1294995912.8240.86.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikfUHHc+-gVkgnRJc722wObLF3TumpK5WSfJVAE@xxxxxxxxxxxxxx> <1295024348.12018.222.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikf3TVJwE_N-OyuS-UhyA8+cgzAG__9hz3AETeM@xxxxxxxxxxxxxx> <AANLkTinJ=PYsC6vbPvU8g2T8NmyohLa=4rd9zfhTMCCO@xxxxxxxxxxxxxx> <AANLkTin1AGxH26158mn37_Oar1PgSSJoJOnGHs+XnxsV@xxxxxxxxxxxxxx> <19768.22912.878633.622270@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTinnrmAxaOVu1fN2qt4N2t-EzpF31sKE-Jpn-y2f@xxxxxxxxxxxxxx> <AANLkTi=1b+amdCA4A3AKxAnR6C65xv2+O3BNbGsp-T7i@xxxxxxxxxxxxxx> <19769.31094.274199.464586@xxxxxxxxxxxxxxxxxxxxxxxx> <1295616468.12018.352.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D3A4203.2050706@xxxxxxxxx> <19775.4623.927492.247420@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Tue, Jan 25, 2011 at 1:10 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Thanks, I have applied your patch, with a minor tweak to make it work
> with Stefano's PHYSTYPE_EMPTY patch.
>
Ian - I am afraid the validation in its current form is going to fail
for vhds with prefix 'tap:aio:vhd:' as I just found out.  I will send
a patch to fix that.  In the mean time, if there is a wiki/doc that
lists the different formats that can be passed through the disk
option, I can verify all of those so as not to introduce any further
regression.

Kamala

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

RE: [Xen-devel] xl and GFX passthrough, Kay, Allen M

Next by Date:

[Xen-devel] Re: [PATCH 2/2] xen: netfront: Drop GSO SKBs which do not have csum_blank., David Miller

Previous by Thread:

Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file, Ian Jackson

Next by Thread:

Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk file while parsing config file, Ian Jackson

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] xl: Perform minimal validation of virtual disk f