Re: [Xen-devel] Crash on boot with 2.6.37-rc8-git3

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Tue, Jan 25, 2011 at 03:19:22PM +0000, Stefano Stabellini wrote:
> On Tue, 25 Jan 2011, Ian Campbell wrote:
> > > unless I am very confused
> > > 
> > > map[i].size -= (map[i].size + map[i].addr) % PAGE_SIZE
> > > 
> > > is not the same as:
> > > 
> > > as map[i].size &= ~(PAGE_SIZE-1): 
> > > 
> > > because it also takes into account the possibility that map[i].addr is
> > > not page aligned.
> > 
> > Oh yes, I didn't notice that aspect of it.
> > 
> > >  It doesn't move map[i].addr upward but still makes sure that
> > > the region ends at a page boundary anyway.
> > 
> > Which returns to my second question ;-) Why do we not need to align addr
> > too?
> 
> My machine can boot fine with a map[i].addr not page aligned.

OK, so then the patch that M A Young came up with ought to do it?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel