WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: fix segfault on device assignement

To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: fix segfault on device assignement
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 25 Jan 2011 15:42:00 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 25 Jan 2011 07:43:53 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1101251535500.7277@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <alpine.DEB.2.00.1101251535500.7277@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2011-01-25 at 15:38 +0000, Stefano Stabellini wrote:
> Fix a xl/libxl segfault when assigning a device to the guest (bug
> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1713).
> 
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Sorry about that,

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r b05892ff0fce tools/libxl/libxl_pci.c
> --- a/tools/libxl/libxl_pci.c Tue Jan 25 15:14:52 2011 +0000
> +++ b/tools/libxl/libxl_pci.c Tue Jan 25 15:34:43 2011 +0000
> @@ -268,7 +268,7 @@ static int libxl_create_pci_backend(libx
>      for (i = 0; i < num; i++, pcidev++)
>          libxl_create_pci_backend_device(gc, back, i, pcidev);
>  
> -    flexarray_vappend(back, "num_devs", libxl__sprintf(gc, "%d", num));
> +    flexarray_vappend(back, "num_devs", libxl__sprintf(gc, "%d", num), NULL);
>  
>      flexarray_vappend(front,
>                        "backend-id", libxl__sprintf(gc, "%d", 0),
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>