|
xen-devel
[Xen-devel] Re: [PATCH] change acquire/release_console_sem() to console_
|
To: |
Torben Hohn <torbenh@xxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock() |
|
From: |
Greg KH <gregkh@xxxxxxx> |
|
Date: |
Thu, 20 Jan 2011 08:34:48 -0800 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, Kees Cook <kees.cook@xxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, James Hogan <james@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, James Morris <jmorris@xxxxxxxxx>, Grant Likely <grant.likely@xxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-parisc@xxxxxxxxxxxxxxx, Magnus Damm <damm@xxxxxxxxxxxxx>, Jiri Slaby <jslaby@xxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, devel@xxxxxxxxxxxxxxxxxxxx, Guy Martin <gmsoft@xxxxxxxxxxxx>, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxx>, Wu Zhangjin <wuzhangjin@xxxxxxxxx>, Florian Tobias Schandinat <FlorianSchandinat@xxxxxx>, Lionel Debroux <lionel_debroux@xxxxxxxx>, Helge Deller <deller@xxxxxx>, Kay Sievers <kay.sievers@xxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>, Tony Lindgren <tony@xxxxxxxxxxx>, cbe-oss-dev@xxxxxxxxxxxxxxxx, Ben Skeggs <bskeggs@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Daniel Vetter <daniel.vetter@xxxxxxxx>, Dave Airlie <airlied@xxxxxxxxxx>, David Brown <davidb@xxxxxxxxxxxxxx>, Francisco Jerez <currojerez@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Namhyung Kim <namhyung@xxxxxxxxx>, Marcin Slusarz <marcin.slusarz@xxxxxxxxx>, Alberto Panizzo <maramaopercheseimorto@xxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, Antonino Daplas <adaplas@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Abhijeet Dharmapurikar <adharmap@xxxxxxxxxxxxxx>, Andres Salomon <dilinger@xxxxxxxxxx>, Werner Fink <werner@xxxxxxx>, Phil Edworthy <phil.edworthy@xxxxxxxxxxx>, linux-geode@xxxxxxxxxxxxxxxxxxx, Alex Deucher <alexdeucher@xxxxxxxxx>, Jerome Glisse <jglisse@xxxxxxxxxx>, Lars-Peter Clausen <lars@xxxxxxxxxx>, Alexey Dobriyan <adobriyan@xxxxxxxxx>, Daniel Mack <daniel@xxxxxxxx>, Nicolas Pitre <nicolas.pitre@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-omap@xxxxxxxxxxxxxxx, Ondrej Zajicek <santiago@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Liam Girdwood <lrg@xxxxxxxxxxxxxxx>, Daniel Walker <dwalker@xxxxxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>, Caglar Akyuz <caglar@xxxxxxxxxxxxxxxxxxxxx>, Geoff Levand <geoff@xxxxxxxxxxxxx>, Jiri Kosina <jkosina@xxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, Guennadi Liakhovetski <g.liakhovetski@xxxxxx>, Kyle McMartin <kyle@xxxxxxxxxxx>, Jean Delvare <khali@xxxxxxxxxxxx>, Paul Mundt <lethal@xxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxx>, Jason Wessel <jason.wessel@xxxxxxxxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, Julia Lawall <julia@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Marcin Kościelnicki <koriakin@xxxxxxxx> |
|
Delivery-date: |
Fri, 21 Jan 2011 04:47:29 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1295539104-13210-1-git-send-email-torbenh@xxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1295539104-13210-1-git-send-email-torbenh@xxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote:
> the -rt patches change the console_semaphore to console_mutex.
> so a quite large chunk of the patches changes all
> acquire/release_console_sem() to acquire/release_console_mutex()
Why not just change the functionality of the existing function to be a
mutex in the rt patches, instead of having to rename it everywhere?
> this commit makes things use more neutral function names
> which dont make implications about the underlying lock.
>
> the only real change is the return value of console_trylock
> which is inverted from try_acquire_console_sem()
>
> Signed-off-by: Torben Hohn <torbenh@xxxxxx>
> CC: Thomas Gleixner <tglx@xxxxxxx>
I don't mind this rename, but is it really going to help anything out?
What's the odds of the -rt portion of this patch ever making it to
mainline?
thanks,
greg k-h
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home