WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 07 of 10] pyxl: Recursively scan type-tree to pro

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 07 of 10] pyxl: Recursively scan type-tree to produce complete binding boilerplate
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Wed, 12 Jan 2011 13:17:24 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 12 Jan 2011 05:18:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1294836642.12018.157.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1294761793@xxxxxxxxxxxxxxxxxxxxxxx> <735df86eab9a758431f9.1294761800@xxxxxxxxxxxxxxxxxxxxxxx> <19756.44770.460102.929525@xxxxxxxxxxxxxxxxxxxxxxxx> <1294836642.12018.157.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 12 Jan 2011, Gianni Tedesco wrote:
> On Tue, 2011-01-11 at 19:26 +0000, Ian Jackson wrote:
> > Gianni Tedesco writes ("[Xen-devel] [PATCH 07 of 10] pyxl: Recursively scan 
> > type-tree to produce complete binding boilerplate"):
> > > pyxl: Recursively scan type-tree to produce complete binding boilerplate
> >
> > I applied patches 1-6.  They touch only pyxl and didn't break the
> > build.
> >
> > However patch 7 contains this:
> >
> > > --- a/tools/libxl/libxl.idl Tue Jan 11 16:01:07 2011 +0000
> > > +++ b/tools/libxl/libxl.idl Tue Jan 11 16:01:08 2011 +0000
> > ...
> > > -                                        ("features", string, True),
> > > +                                        ("features", string),
> >
> > This makes a substantive change to both the interface and the
> > generated code, and wasn't mentioned in the comment.  I'm not
> > convinced it's a change that's appropriate during feature freeze.
> 
> We discussed this off-list at the time I was writing it. I think with
> one of the other guys. We decided that const char * in the interface was
> a bad idea since it imposed an allocation policy where no reason for it
> actually existed in the code. I could have worked around this by casting
> everything in the python bindings but we felt that was an ugly solution
> and not a good precedent to set.
> 

I might have verbally misled Gianni to think that a change like this
would be appropriate.
Bu thinking twice about it, even though it appears correct and it is
just one line, it doesn't meet the criteria.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>