WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenp

To: Han-Lin Li <astercase@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 6 Jan 2011 17:43:07 +0000
Cc: Olaf Hering <olaf@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 Jan 2011 09:45:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTi=o_pDNBoW1-qDZ_jtWOhmeWgJqBoqhDCUz371e@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <AANLkTi=o_pDNBoW1-qDZ_jtWOhmeWgJqBoqhDCUz371e@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Han-Lin Li writes ("[Xen-devel] [PATCH] fix "Error flushing ioemu cache" 
message in xenpaging"):
> While using xenpaging, "Error flushing ioemu cache" message will be shown
> on screen even if the "flush-cache" command is sent to xenstore correctly.
> That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
> return non-zero value when operation fail.  But
> xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
> which is zero when operation fail. So,  we should invert the return value from
> xs_write() before use it as return value to prevent printing those
> incorrect error messages.

I'd like to give Olaf Hering a chance to respond, though, as it seems
he hasn't already.

Perhaps xc_mem_paging_flush_ioemu_cache ought to return -1 on error
and 0 on success, like most other xc functions ?

Thanks,
Ian.

> 
> ---
> Signed-off-by: Han-Lin Li <Han-Lin.Li@xxxxxxxxxxx>
> 
> diff -r 89116f28083f tools/xenpaging/xc.c
> --- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
> +++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
> @@ -62,7 +62,7 @@
>      xs_daemon_close(xsh);
> -    return rc;
> +    return !rc;
>  }
>  int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
> unsigned long ms)
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>