WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][qemu-xen] Change tap device mac address to preve

To: Miroslav Rezanina <mrezanin@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][qemu-xen] Change tap device mac address to prevent change of bridge's mac
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 21 Dec 2010 13:36:14 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 21 Dec 2010 05:37:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1184158838.29197.1292937183439.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1184158838.29197.1292937183439.JavaMail.root@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-12-21 at 13:13 +0000, Miroslav Rezanina wrote:
> Qemu tap device is created with random mac address and then add to bridge. 
> Due to linux kernel handlig, bridge change its mac address to tap mac in case 
> tap mac is lower than bridge one. This can lead to short network breakage for 
> dom0 and guests. 
> 
> This patch set tap device mac adress to FE:FF:FF:FF:FF:FF to ensure tap 
> device mac is always higher then bridge one.
> 
> Signed-off-by: Miroslav Rezanina <mrezanin@xxxxxxxxxx>

Thanks. This needed a different fix in xen-unstable.hg because tap
devices are handled by the hotplug scripts and not qemu-ifup there. See
the recent thread "tools/hotplug/Linux: Ensure tap devices receive a
dummy MAC address".

My backport to xen-4.0-testing looked a lot like yours.

Ian.


> 
> Patch:
> --
> diff --git a/i386-dm/qemu-ifup-Linux b/i386-dm/qemu-ifup-Linux
> index bcbee92..c706a10 100644
> --- a/i386-dm/qemu-ifup-Linux
> +++ b/i386-dm/qemu-ifup-Linux
> @@ -33,5 +33,8 @@ then
>     fi
>  fi
>  
> +# We have to change mac address of tap device to not change bridge mac
> +ip link set $1 addr fe:ff:ff:ff:ff:ff
> +
>  ifconfig $1 0.0.0.0 up
>  brctl addif $bridge $1 || true



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>