WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 18/21] xenpaging: prevent page-out of first 16MB

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 18/21] xenpaging: prevent page-out of first 16MB
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 17 Dec 2010 13:18:24 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Dec 2010 04:19:36 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1292588314; l=1450; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=dkmHLQQZb7NG/7CEYJQgHFW1F7M=; b=qXyLfC0Hazn8hDkAKpxtF3jSztZEk5vO4CW0nI/0GZoCAN+kx78IKCRKAncKiXK35m5 kjnvg/sqPYnVy53pdxaVQc8tD3sWm63mbLkR2/1QmDfK9PtbsWSem0DrMpcmIdPxIIj4I H4tg4qbtRRWdQiPiUl6rxcnmkG5ARykBtOk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D0B3B550200007800028A25@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101126134901.384130351@xxxxxxxxx> <20101126134907.311234491@xxxxxxxxx> <20101216165942.GA17353@xxxxxxxxx> <4D0B3B550200007800028A25@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Dec 17, Jan Beulich wrote:

> >>> On 16.12.10 at 17:59, Olaf Hering <olaf@xxxxxxxxx> wrote:
> > On Fri, Nov 26, Olaf Hering wrote:
> > 
> >> This is more a workaround than a bugfix:
> >> Don't page out first 16MB of memory.
> >> When the BIOS does its initialization process and xenpaging removes pages,
> >> crashes will occour due to lack of support of xenpaging.
> > 
> > While looking at this again, I came up with this change. Any idea whats
> > at 512K during BIOS startup?
> > 
> > 
> >  Subject: xenpaging: prevent page-out of gfn 0x80
> > 
> > Add a workaround for missing handling of paged-out pages during BIOS 
> > startup.
> > For some reason, only gfn 0x80 is affected.
> > 
> > (XEN) HVM3: HVM Loader
> > (XEN) traps.c:649:d3 Bad GMFN 80 (MFN ffffffffff) to MSR 40000000
> 
> This clearly is another place where page-in needs to be triggered.

Yes, thats true.
I had a printk in gfn_to_mfn for some months, and it did not trigger
during my testing. But then, I also had the patch which keeps the first
16MB in memory.

So as it stands, gfn_to_mfn() should call p2m_mem_paging_populate() at
least, even if that does not fix this crash.
I think the few gfn_to_mfn* variants should not return the paging types
anymore, and just sleep until the page is back. Thats something for next
year, as time runs out for me.

And: I think the various redefines of those functions/macros can go as well.


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>