WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] patch fix-rx-packets-accounting

To: Paul Durrant <paul.durrant@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 15 Dec 2010 10:45:05 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 15 Dec 2010 07:48:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1292348283-5786-2-git-send-email-paul.durrant@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1292348283-5786-1-git-send-email-paul.durrant@xxxxxxxxxx> <1292348283-5786-2-git-send-email-paul.durrant@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Dec 14, 2010 at 05:38:00PM +0000, Paul Durrant wrote:

Shouldn't there also be a patch to move the tx_bytes?

> ---
>  drivers/xen/netback/netback.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/xen/netback/netback.c b/drivers/xen/netback/netback.c
> index 1a4a20e..066d140 100644
> --- a/drivers/xen/netback/netback.c
> +++ b/drivers/xen/netback/netback.c
> @@ -1519,9 +1519,6 @@ static void net_tx_submit(struct xen_netbk *netbk)
>               skb->dev      = netif->dev;
>               skb->protocol = eth_type_trans(skb, skb->dev);
>  
> -             netif->stats.rx_bytes += skb->len;
> -             netif->stats.rx_packets++;
> -
>               if (skb->ip_summed == CHECKSUM_PARTIAL) {
>                       if (skb_checksum_setup(skb)) {
>                               DPRINTK("Can't setup checksum in 
> net_tx_action\n");
> @@ -1537,6 +1534,9 @@ static void net_tx_submit(struct xen_netbk *netbk)
>                       continue;
>               }
>  
> +             netif->stats.rx_bytes += skb->len;
> +             netif->stats.rx_packets++;
> +
>               netif_rx_ni(skb);
>               netif->dev->last_rx = jiffies;
>       }
> -- 
> 1.5.6.5
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel