WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpagin

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging
From: Han-Lin Li <astercase@xxxxxxxxx>
Date: Wed, 15 Dec 2010 12:04:57 +0800
Delivery-date: Tue, 14 Dec 2010 20:06:10 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=8y+4EGQ0GaG5KFJdlFIaeXjEeDB/GsMqcR4x7IDwbIc=; b=UbnsyM889z0EzMY1wbbEwBxP9yS5uN1GkidsedtxrvAKGzDcqWe3H2fGRTHb8WQNPV 4DsMI/AEZFr/f1jtZMdBKNDol2F8VnUHGBuH+7oPakyoFOUL9z2PUUxH2sOGWPIjgqkq h6sgKvXc8CxWaX+L7zFR64NYpwDCV/JN1iW1k=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=Q7JgbDMuavkgGbCAEVTjFXiO1OaceClW9aLYtVJpzScL6TMTNOMrPE0JZB8V/1JXB5 DBk7XT2CrhEyCXYQxhtZ8vgJUi/E7lJjN0vYVA5pGYZ1GlXObs7bhlFryoH1mzPY4z/d d2C4Mw4wKJuDtFcdquF/IblgZ2Q+lE23bnvsg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
While using xenpaging, "Error flushing ioemu cache" message will be shown
on screen even if the "flush-cache" command is sent to xenstore correctly.
That is because xenpaging assume xc_mem_paging_flush_ioemu_cache()
return non-zero value when operation fail.  But
xc_mem_paging_flush_ioemu_cache() return the return value from xs_write()
which is zero when operation fail. So,  we should invert the return value from
xs_write() before use it as return value to prevent printing those
incorrect error messages.

---
Another problem is that the "flush-cache"  command isn't supported by
xenstore until you apply the patch below
http://thread.gmane.org/gmane.comp.emulators.xen.devel/91768/focus=91770
This patch isn't merged to unstable version yet.
Users need to merge this patch manually to make this function work correctly.
Anyone knows why this patch isn't merged to the unstable version?

---
Signed-off-by: Han-Lin Li <Han-Lin.Li@xxxxxxxxxxx>

diff -r 89116f28083f tools/xenpaging/xc.c
--- a/tools/xenpaging/xc.c      Wed Dec 08 10:46:31 2010 +0000
+++ b/tools/xenpaging/xc.c      Wed Dec 15 19:23:53 2010 +0800
@@ -62,7 +62,7 @@
     xs_daemon_close(xsh);
-    return rc;
+    return !rc;
 }
 int xc_wait_for_event_or_timeout(xc_interface *xch, int xce_handle,
unsigned long ms)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] fix "Error flushing ioemu cache" message in xenpaging, Han-Lin Li <=