| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH]: xl: don't segfault parsing disk configs, suppor
|
To: |
Gianni Tedesco <gianni.tedesco@xxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH]: xl: don't segfault parsing disk configs, support NULL physpath and ioemu: |
|
From: |
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
|
Date: |
Tue, 14 Dec 2010 17:40:44 +0000 |
|
Cc: |
Christoph Egger <Christoph.Egger@xxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Narasimhan <kamala.narasimhan@xxxxxxxxx>, yang.z.zhang@xxxxxxxxx, Kamala |
|
Delivery-date: |
Tue, 14 Dec 2010 09:41:58 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1292326253.11246.25.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Newsgroups: |
chiark.mail.xen.devel |
|
References: |
<1292326253.11246.25.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Gianni Tedesco writes ("[Xen-devel] [PATCH]: xl: don't segfault parsing disk
configs, support NULL physpath and ioemu:"):
> Resending due to another user reported running in to this. Applies with
> offsets.
...
> Switch to a state machine parser since it's easier to handle all these
> exotic cases without segfaulting. NULL physpaths are now allowed and a
> dodgy hack is introduced to skip over the "ioemu:" prefix for a
> virtpath. Also fixes a leak of buf2.
Thanks, but I think the last time we had this we had some negative
feedback about the comprehensibility of this approach.
Perhaps a regexp- or flex- or bison- based approach would be better ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home