WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4 of 4] Support new xl command cpupool-numa-split

On Wed, 2010-12-08 at 13:17 +0000, Juergen Gross wrote:
> On 12/08/10 14:12, Ian Campbell wrote:
> > On Wed, 2010-12-08 at 12:20 +0000, Juergen Gross wrote:
> >> On 12/08/10 12:16, Ian Campbell wrote:
> >>> Can this loop be merged with the preceding loop, with the body being the
> >>> else case of the if?
> >>
> >> No. I have to add new cpus first to avoid a cpupool without cpus in 
> >> between.
> >
> > ok.
> >
> > I was thinking that because this function only gets here if there is a
> > single pool that all CPUs must be in that pool -- but that's not
> > actually true is it? Even if that were the common case there's nothing
> > to enforce that.
> 
> Perhaps I should add a comment to avoid a problem later...

That would certainly help.

The alternative would be to bail out if all cpus are not associated with
Pool-0, not just when there are > 1 pools. That would be consistent with
the function only acting on the default configuration.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel