WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/4] amd iommu: Large io page support - enablemen

To: Wei Wang2 <wei.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/4] amd iommu: Large io page support - enablement
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 03 Dec 2010 08:24:53 -0800
Cc:
Delivery-date: Fri, 03 Dec 2010 08:27:43 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=AKyPrWo1FEYZJx41vFeguUwXMPLouTWY41Ibczx3GEs=; b=PTRNB2eXlwm133TPEbTleo8KRwKf9PFlkMSJSmG4q4B4zLsSKmWZhoyEPEW4+PNBeG XdEK2ESgmJIgeDcfnG5m8u4cv46jSv4euBnpJT3FiSUqSSxCMrFVRpabGuqb+urxoMek hNf5o+KtVjVD5abAHfrj0mw0O40ny3HNtjduY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=I4CewV8IpaGsbFrd8zeS+w1n6xKgRD73T9zC2fHUufg49PedS4kVmB0cS9rm0rftGf bX060SowRoxMCYoZWoF1MdSq5gwOHJQ6nIb5l4hfZm1ar6ExAprZZFeJ7y8plbcpyePX cgfXBop8kf5yuSktnQX2+hyQT+0EFZX6yOxYo=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201012031703.44942.wei.wang2@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuTBp1mFN+lNUB14EG/hqZ0Py5WHw==
Thread-topic: [Xen-devel] [PATCH 3/4] amd iommu: Large io page support - enablement
User-agent: Microsoft-Entourage/12.23.0.091001
Well, let's see. The change to p2m_set_entry() now allows (superpage) calls
to the iommu mapping functions even if !need_iommu(). That seems a semantic
change. Also I don't want the superpage command-line parameter, but I see
why you added it, as you couldn't be bothered to fix up the Intel side to
work properly, so you left in the onld p2m_set_entry() code for that case.
That's unacceptable. Get rid of the command-line parameter, get rid of the
new [un]map_pages iommu hooks and extend the existing map/unmap hooks
instead, and naturally do that for the Intel side as well as the AMD side
(of course, on the Intel side you can just do a dumb implementation of
map_pages which just loops over the existing single-page-at-a-time code --
you need to keep the Intel side working, but you don't have to do the work
to make it faster than it is already).

I'm going to stop reading this patch series now and wait for a better one.

 -- Keir

On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:

> Enable super iommu support on amd systems.
> Thanks,
> We
> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
> --
> Legal Information:
> Advanced Micro Devices GmbH
> Sitz: Dornach, Gemeinde Aschheim,
> Landkreis München Registergericht München,
> HRB Nr. 43632
> Geschäftsführer:
> Alberto Bozzo, Andrew Bowd
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel