WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: dom0 pvops crash apparently due to guest migration

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: dom0 pvops crash apparently due to guest migration
From: Keir Fraser <keir@xxxxxxx>
Date: Tue, 30 Nov 2010 12:17:17 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 30 Nov 2010 04:18:22 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=R8cpR9vRBxXd1IMZC/yovBzZ/Qku2GzCGqeeSoewJC8=; b=HG6uVqb6ieTtbxrqIz78ujgDVL4Cizk/OnBlyH114cnQb6891i00bV8VORpOSxDynA Qf5bm4wEGmuVBxNBQmQfhxBfqIRDRn+8oFCRFHXNV2UDM8qqxNayMN3bXVnkjAV+Nl0X 7bph4HD2+0vvTZIHV58+yiIhsC88MbneJH3+E=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=FltTbI88X75jzoBH78Jpu73NCvrGbWUgl/Yq4l1pnGqD1GBQzlZHJHrAhYlNp/X5+Z pILS2y7LviJoqsuJA7nCL4F+sX4cUPPQ83rMLTxyJpXOOdMXo7GCV7Aw9K8M7HbgXkX2 W5OGA7wyPtgNAImIq8Sydq/Py3OZ/ESYTr0fM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CF3F6BC.3020906@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuQiIdLyGGJZA1Eak+J4kJY2gTVaw==
Thread-topic: [Xen-devel] Re: dom0 pvops crash apparently due to guest migration
User-agent: Microsoft-Entourage/12.27.0.100910
On 29/11/2010 18:53, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

> Hm, I'm still not really sure why alloc_vm_area() does a
> vmalloc_sync_all in the first place...  But that BUG shouldn't happen
> regardless.

I think vmalloc_sync_all() is required only if alloc_vm_area()'d regions are
used as hypercall buffers. I'm not sure if they ever are, these days. The
sync wouldn't be needed for allocated regions use as shared rings, for
example. You might be able to do a quick audit of users and then remove the
vmalloc_sync_all(). Presumably if v_s_a is planned to go away it'd be nice
to get rid of this usage for that reason also.

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel