WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] hvm passthru: Fix a xen-unstable crash

To: Wei Wang2 <wei.wang2@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] hvm passthru: Fix a xen-unstable crash
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 29 Nov 2010 17:32:06 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Mon, 29 Nov 2010 09:33:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201011291747.09794.wei.wang2@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C9196DCE.B449%keir@xxxxxxx> <alpine.DEB.2.00.1011291547230.14723@kaball-desktop> <201011291747.09794.wei.wang2@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Mon, 29 Nov 2010, Wei Wang2 wrote:
> On Monday 29 November 2010 16:49:05 Stefano Stabellini wrote:
> > On Mon, 29 Nov 2010, Keir Fraser wrote:
> > > Stefano,
> > >
> > > Can you ack/nack this patch please.
> >
> > ack.
> >
> > I think we also need this:
> >
> >
> > diff -r 79b71c77907b xen/arch/x86/physdev.c
> > --- a/xen/arch/x86/physdev.c        Wed Nov 24 10:20:03 2010 +0000
> > +++ b/xen/arch/x86/physdev.c        Mon Nov 29 15:26:03 2010 +0000
> > @@ -236,7 +236,8 @@ static int physdev_unmap_pirq(struct phy
> >          spin_lock(&d->event_lock);
> >          ret = unmap_domain_pirq_emuirq(d, unmap->pirq);
> >          spin_unlock(&d->event_lock);
> > -        goto free_domain;
> > +        if ( unmap->domid == DOMID_SELF || ret )
> > +            goto free_domain;
> >      }
> >
> >      ret = -EPERM;
> >
> >
> > Wei, could you give it a try, in addition to your patch?
> >
> > Thanks,
> >
> > Stefano
> 
> Hi Stefano,
> This patch works well together with my patch on our testing system. No more 
> crashes.

Thanks!
Keir, can you please apply both patches?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>