This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xenalyze: Use types which have consistent sizes

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles
From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Date: Thu, 25 Nov 2010 12:09:03 +0000
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 25 Nov 2010 04:10:23 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=2ngkXrOc/nlwXov2+fDNQgjNMdsOXgzjA5vdomIkgXw=; b=FiFJ3p5eGETHv1CZnno52OdtDtUVSCTFeJqi1pKUNRx8qgjM6ZWWW2ObDf318hXAbr V9lQsELFuWQxJn3p8DBPhTlEBNlBjJpOGJiAVeI10WrWW2NLgKoZOz0yOoDiSnrip/5Q ZJTJvP+riw+Vo2SIG20BSSNGOOCB4mdp4Qqg4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=QXSu5nyB3vQJL8XuOAHy8xrbegDo+QX3se2Df7AGjFuOhQ96irMWF1sEX3aYYGD1ai Ua5Csqf5fFPvtPU5JZtpHb7CNeAkSm5kL/6jUnEMsWmmCDaa6a75VIHIQpji/eEXulDO ox3Ky9theJH4v/4cBheZLEjpuEb+l8uME98ns=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101125112201.GI19638@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop> <20101125111758.GA13724@xxxxxxxxx> <20101125112201.GI19638@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, Nov 25, 2010 at 11:22 AM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> At 11:17 +0000 on 25 Nov (1290683878), Olaf Hering wrote:
>> On Mon, Nov 22, George Dunlap wrote:
>> > Always use [unsigned] long long for 64-bit, [unsigned] int for 32-bit.
>> George,
>> there are two unsigned long left in hvm_mmio_assist_process().
>> I think the sizeof(unsigned long) should be sizeof(unsigned int).
> Why not use the stdint.h explicit-width types?

Because using them with printf() is ugly and clunky?

I was thinking at some point I'd need to go over to using stdint
types, but was putting it off as I deemed it unpleasant.  However, if
simply not using "long" works for x32 and x64, I'm happy.  I'd
consider patches switching over to stdint.h, but I probably won't
write one myself unless there's a compelling reason to do so.


> Tim.
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, Xen Platform Team
> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list