This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] fix "xm block-detach 0 ..." for extended-ID devi

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix "xm block-detach 0 ..." for extended-ID devices
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 19 Nov 2010 17:56:45 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 19 Nov 2010 10:02:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CE5652D0200007800023111@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4CE5652D0200007800023111@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jan Beulich writes ("[Xen-devel] [PATCH] fix "xm block-detach 0 ..." for 
extended-ID devices"):
> Simply taking stat()'s st_rdev doesn't work here, as the minor is
> split into two parts, the major is present, and the "extended" bit
> isn't set.
> @@ -20,7 +20,11 @@ def blkdev_name_to_number(name):
> -        return (devname, os.stat(n).st_rdev)

This seems to me to be entirely wrong.  When you block detach you
should be providing the device name according to the Xen guest device
naming scheme, not a local device path (which may have different major
and minor numbers).

If you just remove the try/except block and always use the following
code, does it work correctly ?


Xen-devel mailing list