[Xen-devel] Re: [PATCH] amd iommu: Fix HV crash with 32bit pv_ops kernel(V2)

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> On 15.11.10 at 14:58, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
> Hi Jan
> Could this new version be a little more clear?
> Thanks,
> Wei

Yes (assuming the header you moved the decl-s to is included by
the producer).

Jan

> On Monday 15 November 2010 13:37:27 Jan Beulich wrote:
>> >>> On 15.11.10 at 11:18, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
>> >
>> >--- a/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h Wed Nov 10 14:56:06
>> > 2010 +0000 +++ b/xen/include/asm-x86/hvm/svm/amd-iommu-proto.h     Fri Nov 
>> > 12
>> > 17:10:31 2010 +0100 @@ -31,8 +31,8 @@
>> >
>> > #define DMA_32BIT_MASK  0x00000000ffffffffULL
>> >
>> >-extern int amd_iommu_debug;
>> >-extern int amd_iommu_perdev_intremap;
>> >+extern bool_t amd_iommu_debug;
>> >+extern bool_t amd_iommu_perdev_intremap;
>> >
>> > #define AMD_IOMMU_DEBUG(fmt, args...) \
>> >     do  \
>>
>> This surely can't be complete: If you had a type mismatch between
>> declaration and definition, the defining code is clearly missing an
>> #include of the #define-ing header.
>>
>> Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel