WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]: Allow HVM guests to use entire address space

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: Allow HVM guests to use entire address space
From: Keir Fraser <keir@xxxxxxx>
Date: Wed, 10 Nov 2010 13:46:36 +0000
Cc: Steven Smith <steven.smith@xxxxxxxxxxxxx>
Delivery-date: Wed, 10 Nov 2010 05:47:20 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=1QMygceOKHd/pOpXJiPLcHflHpgxJHYRRzk2u9Q2gxA=; b=vr8ErWwMboJYBbe9/C5wuePcj4uYmeYsVC7JIbQPyWySZPlnzKymnjpMYTW/9yeNXu rou3w4Oe91BJfL1y+TPuTi0ygcuxwYo2bzQeJN3SsHMlzcRcv23kOjaKVockWgdazOhI ha/0psOluYOD5j3ri2kcNNUF9tHmy7JrEiuCM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=gqJ9UZUkdnGf0CIclolrHJ4mKA2eIaEagRh9YhZAPoTTnv3mAf5gVtp344QxBUNu0Q bEWi3dK3OSuKzruSefJMob4b6/GMcP39S1OX2hMZyjEelFOZcPKxafMvEAG9IuQfYmVj 2aAuzWSZcgjfEMevNxbtyeab/y5Wkz3DB9ijk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1289396415.22729.183.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuA3bE+TfnCekWYxUONG918Dk3ecA==
Thread-topic: [Xen-devel] [PATCH]: Allow HVM guests to use entire address space
User-agent: Microsoft-Entourage/12.27.0.100910
On 10/11/2010 13:40, "Gianni Tedesco" <gianni.tedesco@xxxxxxxxxx> wrote:

> HVM guests are allowed to use the entire virtual address space for
> whatever they want, without any Xen hole.  __addr_ok() is therefore
> always true for such guests.

This one got nacked and the bug was instead fixed by xen-unstable:21456 aka
xen-4.0-testing:21169. So we don't need this patch, thank you. ;-)

 -- Keir

> Signed-off-by: Steven Smith <steven.smith@xxxxxxxxxxxxx>
> 
> diff -r 7188d1e4b0e1 xen/include/asm-x86/x86_64/uaccess.h
> --- a/xen/include/asm-x86/x86_64/uaccess.h Tue Nov 09 12:00:05 2010 +0000
> +++ b/xen/include/asm-x86/x86_64/uaccess.h Wed Nov 10 13:34:52 2010 +0000
> @@ -20,7 +20,8 @@ void free_compat_arg_xlat(unsigned int c
>   * non-canonical address (and thus fault) before ever reaching VIRT_START.
>   */
>  #define __addr_ok(addr) \
> -    (((unsigned long)(addr) < (1UL<<48)) || \
> +    (is_hvm_vcpu(current) || \
> +     ((unsigned long)(addr) < (1UL<<48)) || \
>       ((unsigned long)(addr) >= HYPERVISOR_VIRT_END))
>  
>  #define access_ok(addr, size) \
> @@ -30,6 +31,7 @@ void free_compat_arg_xlat(unsigned int c
>      (access_ok(addr, (count)*(size)))
>  
>  #define __compat_addr_ok(d, addr) \
> +    (is_hvm_vcpu(current) || \
>      ((unsigned long)(addr) < HYPERVISOR_COMPAT_VIRT_START(d))
>  
>  #define __compat_access_ok(d, addr, size) \
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>