WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xend: drbd improvements

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: drbd improvements
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Tue, 09 Nov 2010 15:21:22 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Berthold Gunreben <bg@xxxxxxx>, Michael Renner <michael.renner@xxxxxxxxxxx>
Delivery-date: Tue, 09 Nov 2010 14:22:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19673.37479.133902.499115@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <fb0498c0cbdd6be20bbc.1289325040@xxxxxxxxxxxxxxxxxxxxxxxxx> <19673.37479.133902.499115@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081112)
Ian Jackson wrote:
> Jim Fehlig writes ("[Xen-devel] [PATCH] xend: drbd improvements"):
>   
>> xend: drbd improvements
>>
>> 1) drbdadm state is debrecated, and the script tries to detect the
>> primary/secondary information from the deprecated message
>> 2) os.popen2 does not work with the array as argument
>> 3) popen2 is deprecated since python2.6
>>     
>
> Forgive my ignorance, but: why does xend need to mess with drbd at
> all ?  Why can't it just open the block device ?
>   

Good question.  I too was surprised to see special casing of drbd within
xend.  Seems c/s 20158 added this code to allow bootloaders (pygrub,
domUloader, et. al.) to work with drbd devices using the 'drbd:resource'
syntax.  Perhaps the author of that patch (cc'd) can provide more
details.  This patch simply makes improvements to the existing code. 
BTW, c/s 20158 also uses popen2() in tools/python/xen/util/blkif.py, so
IMO a V2 will be needed if this patch is considered.

> xl and libxl don't have any drbd functionality so if this is necessary
> it's a missing feature.
>   

Micheal, does xl/libxl need this functionality?

Regards,
Jim


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>