This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] tools: xl: more const-correctness

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [PATCH] tools: xl: more const-correctness
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 9 Nov 2010 12:00:53 +0000
Delivery-date: Tue, 09 Nov 2010 04:01:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19672.11748.708610.282143@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19672.11748.708610.282143@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I wrote:
> tools: xl: more const-correctness

Looks like I was a bit over-enthusiastic:

# HG changeset patch
# User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
# Date 1289304005 0
# Node ID 7188d1e4b0e1ce409912dfa6d17f853720959053
# Parent  cf7a126298fb8d16c564592bb95d18b7dca0a633
tools: libxl: Fix some "const const"s introduced in 711cb4229900

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r cf7a126298fb -r 7188d1e4b0e1 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c  Tue Nov 09 11:50:37 2010 +0000
+++ b/tools/libxl/xl_cmdimpl.c  Tue Nov 09 12:00:05 2010 +0000
@@ -2161,7 +2161,7 @@ int main_console(int argc, char **argv)
     return 1;
-static int vncviewer(const const char *domain_spec, int autopass)
+static int vncviewer(const char *domain_spec, int autopass)
     libxl_vncviewer_exec(&ctx, domid, autopass);
@@ -5323,7 +5323,7 @@ int main_tmem_freeable(int argc, char **
 int main_cpupoolcreate(int argc, char **argv)
-    const const char *filename = NULL;
+    const char *filename = NULL;
     const char *p;
     char extra_config[1024];
     int dryrun = 0;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>