| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak
|
To: |
Milton Miller <miltonm@xxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak |
|
From: |
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |
|
Date: |
Mon, 8 Nov 2010 11:34:11 -0500 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, jirislaby@xxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jbarnes@xxxxxxxxxxxxxxxx, Jiri Slaby <jslaby@xxxxxxx> |
|
Delivery-date: |
Mon, 08 Nov 2010 08:36:45 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<xenfront-reffix-fixreq@xxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1288881090-27335-1-git-send-email-jslaby@xxxxxxx> <xenfront-reffix-fixreq@xxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Thu, Nov 04, 2010 at 12:27:07PM -0600, Milton Miller wrote:
> On 2010-11-04 at about 14:31:30 Jiri Slaby wrote:
> > Stanse found that when pdev is found and has no driver a reference is
> > leaked in pcifront_common_process. So add pci_dev_put there. For the
> > pdev == NULL case, pci_dev_put(NULL) is fine.
>
> While that may be true, the dev_err(&pcidev->dev ... is a NULL pointer
> deref.
I've put the fix in the branch (stable/xen-pcifront-fixes) that I will ask Linus
to pull.. but what options did you need to find this?
I tried to run this before putting your and Milton fix in:
konrad@phenom:~/tar/stanse-1.1.2$ java -jar ./stanse.jar
~/work/linux/drivers/pci/xen-pcifront.c
Stanse version "1.1.2"
Copyright (c) 2008-2010 Masaryk University, Brno
STANSE_HOME not specified. Using the location of stanse.jar.
Checking for bugs:
<-> File: /home/konrad/work/linux/drivers/pci/xen-pcifront.c
<-> --------------------------------
Done.
And no warnings?
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home