This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [Patch] Fixing Xsave Guest Save/Restore on non-xsave pla

To: Haitao Shan <maillists.shan@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] Fixing Xsave Guest Save/Restore on non-xsave platform
From: Keir Fraser <keir@xxxxxxx>
Date: Mon, 08 Nov 2010 15:46:28 +0000
Delivery-date: Mon, 08 Nov 2010 07:47:29 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=MLh8ShocrsnJPAj0Xd5fPjaMXzatheO0S9oCc2wnF2U=; b=PPvxNY/ScJRUfK0Db5lytrYjTN6jzpA6cc0h0tWXmvdC0qRfIw4G78eGItgZ1WLh8X D9tM7EJNOFc6ZUBp9Dy3hVPIV3Ulclb3srffkBPQeCtmUXnDpWvYfQ7rS4FKX/UNw5bE G30ERgsG5SGWQ1rWkQ55DWBNXEoynRK1hw14Y=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=HDxCX4Nify8c6qnXh0V+FGtysW2vG9gaWkGV1Tmz5jOuqYhKzR89sn1dB2MY6pKzly XDyNJ2h5Y7xL1tuB4uWAs+uUHERlqNt3kyMd8eE9AY1kTudXQFksI1EUY8c1ySp7Dkei cTGspTjN1bp+iT65Q4+5us5oizZBOwUTh0XbM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTimuEqFt4CELnwV=602t+hHmVGtBy2ifC2rrFhNw@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act/XBsvS4X/IGm5XEG6BG0fQSJZ5Q==
Thread-topic: [Xen-devel] [Patch] Fixing Xsave Guest Save/Restore on non-xsave platform
User-agent: Microsoft-Entourage/
Okay, I have committed your fixed patch to xen-unstable. Note that you have
not added back all my reversions: I also reverted the changes you made to
expose XSAVE/AVX via cpuid. The reason was that you were passign through the
host CPU's CPUID feature flags, but not taking into account whether XSVAE
was disabled in the hypervisor by use_xsave=0 (the default!).

 -- Keir

On 08/11/2010 13:21, "Haitao Shan" <maillists.shan@xxxxxxxxx> wrote:

> Hi, Keir,
> Sorry for the xsave-introduced regression bug. I have fixed and
> attached the patch with this email.
> xsave-migration.patch contains all the changes you have reverted plus
> the fix I made.
> xsave-migration-fix.patch only contains the fix I made based on
> original xsave patch series.
> I have tested the patch in the following senarios:
> 1> Non-xsave platform
> 2> Xsave-capable platform, guest does not support xsave, xen support xsave
> 3> Xsave-capable platform, guest does support xsave, xen supports xsave
> 4> Guest (non-xsave) saved on platform without xsave, restored on a
> Xsave-capable system.
> All passed.
> Could please have review? Thanks!
> Again, sorry for the regression caused.
> Signed-off-by: Shan Haitao <haitao.shan@xxxxxxxxx>
> Signed-off-by: Han Weidong <weidong.han@xxxxxxxxx>
> Shan Haitao
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>