WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] pygrub: support grub2 "(hdX, msdosY)" partition

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] pygrub: support grub2 "(hdX, msdosY)" partition syntax
From: Mike Viau <viaum@xxxxxxxxxxxxxxx>
Date: Sat, 6 Nov 2010 22:29:11 -0500
Cc: ian.campbell@xxxxxxxxxx, stefano.stabellini@xxxxxxxxxxxxx
Delivery-date: Sat, 06 Nov 2010 19:29:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
Importance: Normal
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> On Thu, 28 Oct 2010 00:06:09 +0200:
>
> On Wednesday 13 October 2010 12:45:35 Stefano Stabellini wrote:
>> On Tue, 12 Oct 2010, Ian Campbell wrote:
>>> # HG changeset patch
>>> # User Ian Campbell
>>> # Date 1286899422 -3600
>>> # Node ID 372959917c012db7d90aad0626a4af6b8f9b186f
>>> # Parent 2b9d32cb419d65622d213f501926c024dcfc306d
>>> pygrub: support grub2 "(hdX,msdosY)" partition syntax
>>>
>>> This appeared in Debian Squeeze at some point.
>>>
>>> Signed-off-by: Ian Campbell
>>
>> applied, thanks
>
> Could you apply it also to xen-4.0? This bug hit me today.
>

Another patch that was reported by a Debian user taken from the bug report at: 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=599243


A simple way to fix this, at least for msdos partitions, is:
--- GrubConf.py.orig    2010-08-29 11:13:20.000000000 -0400
+++ GrubConf.py 2010-10-05 23:27:57.000000000 -0400
@@ -76,7 +76,7 @@
         if val is None:
             self._part = val
             return
-        val = val.replace("(", "").replace(")", "")
+        val = val.replace("(", "").replace(")", "").replace("msdos", "")
         self._part = int(val)
     part = property(get_part, set_part)


Not sure what the pros and cons would be between the two patches, but I thought 
I should just share the alternatives :)


-M
                                          
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>