 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with _FORTIFY_S
| To: | Olaf Hering <olaf@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with _FORTIFY_SOURCE |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Wed, 3 Nov 2010 12:50:58 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 03 Nov 2010 05:51:45 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20101102223841.GA3932@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <20101102223841.GA3932@xxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Olaf Hering writes ("[Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with
_FORTIFY_SOURCE"):
> In function 'snprintf',
> inlined from 'init_directories' at block-vvfat.c:868:10,
> inlined from 'vvfat_open' at block-vvfat.c:1065:24:
> /usr/include/bits/stdio2.h:65:3: warning: call to __builtin___snprintf_chk
> will always overflow destination buffer
Thanks, I have applied both of these patches to qemu-xen-unstable.
However: have you checked whether these problems exist in qemu
upstream ? With Anthony's work on upstreaming Xen support in qemu
coming along well, we should be thinking about sending fixes like this
upstream.
When we switch to the upstream-based qemu we won't want to carry a lot
of patches like this one.
Regards,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: [PATCH] x86/pvclock-xen: zero last_value on resume, Ian Campbell |
|---|---|
| Next by Date: | Re: [Xen-devel] audit_p2m errors, p2m_mmio_direct turns into p2m_ram_logdirty, Olaf Hering |
| Previous by Thread: | [Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with _FORTIFY_SOURCE, Olaf Hering |
| Next by Thread: | Re: [Xen-devel] [PATCH] qemu/block-vvfat.c: fix warnings with _FORTIFY_SOURCE, Olaf Hering |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
