This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 22275:e95dc0eb

To: "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 22275:e95dc0eb152d and 22285:36a317494429
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 3 Nov 2010 12:28:58 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 03 Nov 2010 05:29:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101029.164220.294796063.kuwa@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20101029.164220.294796063.kuwa@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 
22275:e95dc0eb152d and 22285:36a317494429"):
> This patch fixes compilation errors by 22275:e95dc0eb152d:
>   ia64/xc_ia64_linux_save.c:797: error: too few arguments to function 
> 'callbacks->switch_qemu_logdirty'
> and applies 22285:36a317494429 to ia64.

Thanks, I have applied this patch.

If I may make an observation: much of ia64/xc_ia64_linux_save.c is
identical to xc_domain_save.c.  This kind of clone-and-hack is
precisely likely to lead to the kind of problems we see here, where
changes and subsequent fixes are made to one copy of the code but not,
or not properly, to the other.

It might be worth trying to reconcile these two versions so that there
is less needless ia64-specific code.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH] libxc, ia64: ia64 counter part of 22275:e95dc0eb152d and 22285:36a317494429, Ian Jackson <=