WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xen: correct size of level2_kernel_pgt

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xen: correct size of level2_kernel_pgt
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 29 Oct 2010 18:37:35 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
Delivery-date: Fri, 29 Oct 2010 10:38:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CCB02DC.1010307@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1288367779-24001-1-git-send-email-ian.campbell@xxxxxxxxxx> <4CCB02DC.1010307@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2010-10-29 at 18:22 +0100, Jeremy Fitzhardinge wrote:
> On 10/29/2010 08:56 AM, Ian Campbell wrote:
> > sizeof(pmd_t *) is 4 bytes on PAE leading to an allocation of only
> > 2048 bytes. The correct size is sizeof(pmd_t) giving us a full page
> > allocation.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
> > ---
> >
> > Applies to mainline since 2.6.36 and to xen.git 2.6.32 based trees
> 
> This is just for 2.6.37?

2.6.36.stable too, I think. I added stable@xxxxxxxxxx to my patch header
but didn't "guilt refresh" so it didn't show up here.

Ian.

> 
>     J
> 
> >  arch/x86/xen/mmu.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> > index c237b81..21ed8d7 100644
> > --- a/arch/x86/xen/mmu.c
> > +++ b/arch/x86/xen/mmu.c
> > @@ -2126,7 +2126,7 @@ __init pgd_t *xen_setup_kernel_pagetable(pgd_t *pgd,
> >  {
> >     pmd_t *kernel_pmd;
> >  
> > -   level2_kernel_pgt = extend_brk(sizeof(pmd_t *) * PTRS_PER_PMD, 
> > PAGE_SIZE);
> > +   level2_kernel_pgt = extend_brk(sizeof(pmd_t) * PTRS_PER_PMD, PAGE_SIZE);
> >  
> >     max_pfn_mapped = PFN_DOWN(__pa(xen_start_info->pt_base) +
> >                               xen_start_info->nr_pt_frames * PAGE_SIZE +
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel