WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix ia64 tools build

To: KUWAMURA Shin'ya <kuwa@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix ia64 tools build
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 29 Oct 2010 08:55:31 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Delivery-date: Fri, 29 Oct 2010 00:56:45 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=uI8aHiQLgibT4Z0kdvsQSD1HsIbW64G4/knFatXLuTs=; b=ZdOsfBjTMO7OGd81CFSxv7PxpynnuzkSVk1JrEuq92QLI8p/fxC0/7ykOtmdkT99zA GJYqBe+TpJwsngAXGZYr3E6jcLGjpoXYk12ewGBOWRvMNAko68+fu5LAz5Z1rGZz/N+s dZ+1K7uYau5/IKQGWx2Pf2PD4HCkJr0JqEyAc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ZTB+KclugP7GvhY8D/lkiXtrDxwA28QBbt8gTPX+f1W/qKcxLBuW2fpeD+x8CA408k XZnZfHq/b4WjQzFXx8C6/ZWE0RB8V5UGhNxJqx1WixWP9C+0bj4u37stT4sxrrGENvIS vPhwUWl05gYwPHKfbFXsD+lx16afIGI45v7xc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101029.163952.304186232.kuwa@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act3PqiRtbSvWXUvGEOeMMExfeq9Aw==
Thread-topic: [Xen-devel] [PATCH] Fix ia64 tools build
User-agent: Microsoft-Entourage/12.26.0.100708
On 29/10/2010 08:39, "KUWAMURA Shin'ya" <kuwa@xxxxxxxxxxxxxx> wrote:

> Ping?
> 
> This patch is still required for ia64 tools.
> 
> Best regards,

I think it would ne neater to have your own
tools/libxc/ia64/ac_ia64_tools.h, and then conditionally include that from
Xen's acenv.h (e.g., dependent on __XEN_TOOLS__). Or revert the bits of c/s
22066 that broke the ia64 build in the first place -- possibly the changes
were based on a false assumption? Cc'ing the author of that patch, Ian
Campbell. In any case, ifdef'ing the bulk of aclinux.h is just gross, I
don't like that fix.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>