This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] no cycles for certain xentrace entries

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] no cycles for certain xentrace entries
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 29 Sep 2010 10:09:29 +0200
Delivery-date: Wed, 29 Sep 2010 01:10:34 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1285747776; l=700; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=U/Gzt29YmgphSMM7TbI3ZxUphBI=; b=JX/EGz/LQLMV3dEED7NXylcPI5JHR1RB15Kp6Pie+Vhza0fe9JIzgisd+3SI2VJOz7Y KkDXZ3hSjM/EzUaJmMBoov9BZgcysgMjzhk9G0SY72sxweCvFXXvalOtpwDo0ir5oKQvs z4RHPovnZM3tv3NgeFCtOvA7RJq+JqX3OxE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100831184458.GA24018@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100831184458.GA24018@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Aug 31, Olaf Hering wrote:

> what is the reason for the empty tsc for some xentracing calls, like
> It makes sorting the resulting logfile by tsc value difficult because
> the 0 entries end up at the beginning of the logfile.

This change appears to work for me.
So, what is the reason for the cycles parameter to trace_var()?

--- xen-4.0.1-testing.orig/xen/common/trace.c
+++ xen-4.0.1-testing/xen/common/trace.c
@@ -631,6 +631,7 @@ void __trace_var(u32 event, bool_t cycle
     if( !tb_init_done )

+    cycles = 1;
     /* Convert byte count into word count, rounding up */
     extra_word = (extra / sizeof(u32));
     if ( (extra % sizeof(u32)) != 0 )

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>