This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 12/12] xen/mtrr: Add mtrr_if support for Xen mtrr

To: stefano.stabellini@xxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 12/12] xen/mtrr: Add mtrr_if support for Xen mtrr
From: Ingo Molnar <mingo@xxxxxxx>
Date: Tue, 28 Sep 2010 14:39:25 +0200
Cc: Stephen Tweedie <sct@xxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Tue, 28 Sep 2010 05:40:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1285676218-26218-12-git-send-email-stefano.stabellini@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <alpine.DEB.2.00.1009281217540.2864@kaball-desktop> <1285676218-26218-12-git-send-email-stefano.stabellini@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-08-17)
* stefano.stabellini@xxxxxxxxxxxxx <stefano.stabellini@xxxxxxxxxxxxx> wrote:

> From: Stephen Tweedie <sct@xxxxxxxxxx>
> Add a Xen mtrr type, and reorganise mtrr initialisation slightly to
> allow the mtrr driver to set up num_var_ranges (Xen needs to do this by
> querying the hypervisor itself.)
> [ Impact: add basic MTRR support ]
> Signed-off-by: Stephen Tweedie <sct@xxxxxxxxxx>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/mtrr/Makefile |    2 +-
>  arch/x86/kernel/cpu/mtrr/main.c   |    3 +
>  arch/x86/kernel/cpu/mtrr/mtrr.h   |    7 ++
>  arch/x86/kernel/cpu/mtrr/xen.c    |  110 
> +++++++++++++++++++++++++++++++++++++
>  4 files changed, 121 insertions(+), 1 deletions(-)
>  create mode 100644 arch/x86/kernel/cpu/mtrr/xen.c

Still NAK, for the very same reasons as we NAK-ed it the previous time: 
/proc/mtrr is a problematic and complicated legacy interface that should 
die. Any modern X server will do the right thing via PAT.

Also, please get the Ack of at least one x86 maintainer for x86 patches.



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>